Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tags links #81

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Make tags links #81

merged 1 commit into from
Mar 29, 2019

Conversation

peterbe
Copy link
Owner

@peterbe peterbe commented Mar 29, 2019

Fixes #43

I'd show a screenshot to demonstrate but there's no visual difference. Which is good.

Copy link
Collaborator

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like how much plumbing this required, but I also can't think of a better way to manage this without some sort of global/inherited state like Redux or React Context.

@mythmon
Copy link
Collaborator

mythmon commented Mar 29, 2019

I left another note about the JSX syntax highlighting issues: github-linguist/linguist#4223 (comment)

@mythmon mythmon merged commit 270577d into master Mar 29, 2019
@mythmon mythmon deleted the 43-make-tags-links branch March 29, 2019 17:30
@peterbe
Copy link
Owner Author

peterbe commented Mar 29, 2019

much plumbing this required, but I also can't think of a better way to manage this without some sort of global/inherited state like Redux or React Context.

I had that thought too! So much drilling. Another thought that crossed my mind was that it's weird that owner and repo are two distinct strings. It should be "bundled" as 1 object. E.g. {owner: 'mozilla', repo: 'whatsdeployed'} since it doesn't make sense broken up.

I'll see about using a context to replacing the drilling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants