-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Compile error for v4.0.0-RC.R3 on macOS 10.15.1 and PHP 7.4.0 #14577
Comments
We're gonna have a look at this. For the time being you can also use MacPorts to install V4. https://docs.phalcon.io/4.0/en/installation#macosx-using-macports |
Thank you for the reply @ruudboon, I'm using brew, and I prefer to not mix package managers; thus I will wait for a fix, when there will be one, and manually install it :) |
@panosru Is this a clean checkout of the repo, or did you builded in this dir on an older os before?
If it's already a clean checkout I can check this behaviour probably during the weekend. Need to borrow a MacBook with Catalina (Can't upgrade yet due to external hardware) |
@ruudboon thanks for the instructions! Although I'm sure I had the correct tag and I did everything on clean clone, I followed your instructions to make sure that it wasn't an issue on my end. The result was the same, I will post you some screenshots that might help you debug that issue. If you need me to try anything, just let me know Thanks! UPDATE: #!/bin/sh
for arg in $@
do
if [ $arg = "-d" ]
then
PHPDEBUG='-d xdebug.idekey=PHPSTORM -d xdebug.remote_autostart=1'
#shift
if [ ${@:$(($#))} = "-d" ]
then
set -- "${@:1:$(($#-1))}"
fi
fi
done
"${PHP_PATH}/php" $PHPDEBUG "$@" Do you think that this might causing the issue? I used to compile Phalcon without any issue before PHP 7.4 though UPDATE2: |
@sergeyklay I'm on PHP 7.4.0 & macOS 10.15.1 before PHP 7.4.0 I was also able to install Phalcon without any issue. |
I just compiled PHP 7.4.0 from source and was able to reproduce the issue |
- See: phalcon/cphalcon#14577 [#170014486]
Status update: I was able to compile and install Phalcon from 4.0.x branch on Debian GNU/Linux 10 using PHP 7.4.0 without any issue. |
I compiled it yesterday in my debian docker image and it worked fine, but on macOS I cannot install it, I'm getting the errors posted in my screenshots... |
Tested with from Zephir master and works fine now. |
@ruudboon I have tried it with both Zephir 0.12.12 and 0.12.13, I still get those errors on macOS: |
@panosru did you do fullclean ? |
@ruudboon of course, I followed the procedure you posted earlier... it is working for you in macOS? :/ |
@panosru see updated comment. |
@ruudboon I have checked out the master branch of zephir (zephir-lang/zephir@a4e9535), then I followed your procedure but when I run
Could it be something related to my end? I didn't had any issue with PHP 7.3.12, when I run |
@panosru The issue is described in #14600 (comment) |
@sergeyklay I read your comment here #14600 (comment) and I replaced everything in For Now
|
@panosru remove this #ifndef zend_uint
#define zend_uint uint
#endif from ./kernel/main.h and try again |
@sergeyklay damn, that was a huge mistake from my side! Thanks for pointing out! Should I replace |
@panosru Return back |
- int zephir_update_static_property_ce(zend_class_entry *ce, const char *property_name, zend_uintptr32_t property_length, zval *value)
+ int zephir_update_static_property_ce(zend_class_entry *ce, const char *property_name, uint32_t property_length, zval *value) |
@sergeyklay Thanks for the support! I have applied that change, then I run Did you guys faced those issues on macOS as well or is it me? :/ |
It it is just on your machine. Do you see
|
@sergeyklay yes, in file Now it works fine :) Thanks a lot! |
@panosru thnx for reporting |
It seems that there is an issue with libtool version that prevents the compiler to run properly.
The text was updated successfully, but these errors were encountered: