Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T16489 apcu fetch 2 #16497

Merged
merged 7 commits into from
Jan 7, 2024
Merged

T16489 apcu fetch 2 #16497

merged 7 commits into from
Jan 7, 2024

Conversation

niden
Copy link
Member

@niden niden commented Jan 6, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Storage\Adapter\Apcu::phpApcuFetch to stop producing warnings due to the second parameter.

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jan 6, 2024
@niden niden requested a review from Jeckerson January 6, 2024 22:48
@niden niden self-assigned this Jan 6, 2024
@niden niden linked an issue Jan 6, 2024 that may be closed by this pull request
@Jeckerson Jeckerson merged commit 9bb774a into phalcon:5.0.x Jan 7, 2024
34 checks passed
@niden niden deleted the T16489-apcu-fetch-2 branch January 8, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: apcu_fetch(): Argument 2 ($success) must be passed by reference
2 participants