Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run migration for fields type of date and datetime #22

Closed
zak-wojtek77 opened this issue Dec 12, 2019 · 1 comment
Closed

Run migration for fields type of date and datetime #22

zak-wojtek77 opened this issue Dec 12, 2019 · 1 comment
Assignees
@Jeckerson
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.1.x

Comments

@zak-wojtek77
Copy link

If I have field name "create_date" of type "datetime" (or "date") and when I run command:
vendor/bin/phalcon migration run --verbose
I see that:
1576145901.8674: ALTER TABLE test MODIFY create_date DATE NOT NULL AFTER name => 1576145901.89 (0.022550106048584)
regardless of whether something has been changed or not

Finally if the table has a lot of records, execution time of SQL queries it is very long.

My database: MySQL 5.5
PHP version: 7.2
Phalcon version: 3.4.1
Phalcon phalcon-devtools version: 3.4.9
@Jeckerson Jeckerson added bug Something isn't working enhancement New feature or request labels Dec 13, 2019
@Jeckerson Jeckerson self-assigned this Dec 13, 2019
@Jeckerson Jeckerson added this to the 1.0.x milestone Dec 13, 2019
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Change exit() to return
d56a960
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Add database selection during DB init
b43f2c9
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Add column size exclusion for DATE types
f00ce31
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Implement helper function db_batch_insert()
863ae79
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Add fzaninotto/faker package
e760d67
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Add test case to test DATE column type
def0ce6
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Fix code style
ed930e0
@Jeckerson Jeckerson mentioned this issue Dec 13, 2019
Merged
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Fix psalm error
76ab25b
Jeckerson added a commit that referenced this issue Dec 13, 2019
@Jeckerson
#22 - Fix phpstan error
2123242
Jeckerson added a commit that referenced this issue Dec 14, 2019
@Jeckerson
Merge pull request #23 from phalcon/fix/#22-field-type-date-datetime
3d2db67 
#22 - Fix unnecessary table alter due DATE and DATETIME columns
This was referenced Dec 14, 2019
Merged
Merged
@Jeckerson
Copy link
Member

Fixed in 3.4.10

@Jeckerson Jeckerson modified the milestones: 1.0.x, 1.1.x Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.1.x
Development

No branches or pull requests
2 participants
@Jeckerson @zak-wojtek77