Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Tests and fixes #1376

Closed
3 tasks done
Jeckerson opened this issue Nov 20, 2019 · 3 comments
Closed
3 tasks done

CLI Tests and fixes #1376

Jeckerson opened this issue Nov 20, 2019 · 3 comments
Assignees
@Jeckerson
Labels
Testing
Milestone
4.0.0

Comments

@Jeckerson
Copy link
Member

Jeckerson commented Nov 20, 2019 •
edited
Loading

  • Manual commands review and execution
  • Bug fixes and small refactors
  • Add more tests, if needed
@Jeckerson Jeckerson added this to the 4.0.0 milestone Nov 20, 2019
@Jeckerson Jeckerson self-assigned this Nov 20, 2019
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Add new method notifyInfo() for CLI output
154a51c
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Bump minimum version of phalcon/ide-stubs
8e2f1e7
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Mass refactor in templates files
5a1da6a
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Remove Generator of Stubs class
71d88c9
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Fix finding correct config.php file
a033e99
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Fix and refactor in Controller Builder
f506606
Jeckerson added a commit that referenced this issue Nov 20, 2019
@Jeckerson
#1376 - Refactor in AllModels Builder
ec35d86
@Jeckerson Jeckerson mentioned this issue Nov 20, 2019
Merged
3 tasks
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Change default value of baseClass
dc233d2
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Remove .php extension in phalcon.bat
1bdb6c5
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Implement lancher.bat
9771c09
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Clean up Command abstract class
f21800c
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Add color output of throwed error in console
08fa70c
Jeckerson added a commit that referenced this issue Nov 21, 2019
@Jeckerson
#1376 - Refactor in Builder Components Classes
d2591be
Jeckerson added a commit that referenced this issue Nov 23, 2019
@Jeckerson
#1376 - Refactor in Snippet Class
c447421
Jeckerson added a commit that referenced this issue Nov 23, 2019
@Jeckerson
#1376 - Fix code style
d8b333d
Jeckerson added a commit that referenced this issue Nov 23, 2019
@Jeckerson
#1376 - Change 'savePath' value from '/tmp' to sys_get_temp_dir()
77b2231
Jeckerson added a commit that referenced this issue Nov 23, 2019
@Jeckerson
Merge pull request #1377 from phalcon/fix/#1376-cli-review
fb5400f 
#1376 - CLI Commands review
@talal424
Copy link
Contributor

#1376 - Fix finding correct config.php file

the added slash '/' in preg_match returns false in windows environment.

would it be simpler if swapped with preg_match('/config\.php$/i', $f->getFilename())

@sergeyklay
Copy link
Contributor

@talal424 Could you please open a new issue with description of the problem and minimal steps to reproduce? Thank you.

@talal424 talal424 mentioned this issue Jan 29, 2020
Closed
@talal424
Copy link
Contributor

done #1426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
Testing
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@sergeyklay @Jeckerson @talal424