Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1330 - AdminLTE 3.0 #1387

Merged
merged 18 commits into from
Dec 6, 2019
Merged

#1330 - AdminLTE 3.0 #1387

merged 18 commits into from
Dec 6, 2019

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Dec 1, 2019

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

image

Thanks

@Jeckerson Jeckerson added this to the 4.0.0 milestone Dec 1, 2019
@Jeckerson Jeckerson self-assigned this Dec 1, 2019
@Jeckerson Jeckerson marked this pull request as ready for review December 6, 2019 16:41
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1387 into 4.0.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             4.0.x   #1387      +/-   ##
==========================================
- Coverage     3.55%   3.53%   -0.03%     
+ Complexity    1133    1097      -36     
==========================================
  Files          115     111       -4     
  Lines         4757    4785      +28     
==========================================
  Hits           169     169              
- Misses        4588    4616      +28
Impacted Files Coverage Δ Complexity Δ
src/Web/Tools/Controllers/ModelsController.php 0% <ø> (ø) 32 <0> (ø) ⬇️
src/Web/Tools/Views/partials/footer.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/Web/Tools/Controllers/ScaffoldController.php 0% <ø> (ø) 8 <0> (ø) ⬇️
src/Web/Tools/Views/models/edit.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/Web/Tools/Views/partials/content.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/Web/Tools/Views/controllers/index.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/Bootstrap.php 0% <ø> (ø) 29 <0> (ø) ⬇️
src/Web/Tools/Controllers/ErrorController.php 0% <ø> (ø) 7 <0> (ø) ⬇️
src/Web/Tools/Views/controllers/view.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
src/Web/Tools/Views/partials/content_header.volt 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8dd00...25e4467. Read the comment docs.

@Jeckerson Jeckerson merged commit 073c110 into 4.0.x Dec 6, 2019
@Jeckerson Jeckerson deleted the feature/#1330-admin-lte-v3 branch December 6, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants