Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1410 - webtools not enabled by default #1450

Merged
merged 4 commits into from
Apr 11, 2020

Conversation

jenovateurs
Copy link
Contributor

Hello team!

By default webtools is no more activated by default.
And I made a two tests to check it.
One to check that without --enable-webtools, there are no webtools files.
With --enable-webtools, I check, if the files webtools.php and webtools.config.php are in the folder.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks

@jenovateurs jenovateurs mentioned this pull request Apr 11, 2020
@jenovateurs
Copy link
Contributor Author

jenovateurs commented Apr 11, 2020

After #1449 will be merge, the error Psalm in this PR will be gone. I just need to rebase after.

@jenovateurs jenovateurs requested a review from Jeckerson April 11, 2020 13:05
@Jeckerson Jeckerson merged commit b63dde6 into phalcon:4.0.x Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants