Fix/issue 1426 windows config path matching #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.0.x #1487 +/- ##
=====================================
Coverage 3.16% 3.17%
=====================================
Files 111 111
Lines 5112 5110 -2
=====================================
Hits 162 162
+ Misses 4950 4948 -2 |
BeMySlaveDarlin
force-pushed
the
fix/ISSUE-1426-windows-path-matching
branch
from
c4d1858 to
b8ddd9c
Compare
Jeckerson
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Regex matching is overhead in just searching filename in path string. Which causes platform dependent issues.
Replaced preg_match in config file comparison by strpos.
Thanks