Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1478: Fixed models generated findFirst() return type #1492

Merged

Conversation

BeMySlaveDarlin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Fixed models generated findFirst() return type

Thanks

@BeMySlaveDarlin BeMySlaveDarlin changed the base branch from master to 4.0.x March 21, 2021 18:15
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/issue-1478-correct-return-type branch 4 times, most recently from 17043d5 to 478f669 Compare March 21, 2021 20:40
@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/issue-1478-correct-return-type branch from 478f669 to 3a1a94d Compare March 21, 2021 20:50
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1492 (3a1a94d) into 4.0.x (94d96c9) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##           4.0.x   #1492   +/-   ##
=====================================
  Coverage   3.15%   3.15%           
=====================================
  Files        111     111           
  Lines       5109    5109           
=====================================
  Hits         161     161           
  Misses      4948    4948           

@Jeckerson Jeckerson added this to the 4.0.x milestone Mar 22, 2021
@Jeckerson Jeckerson linked an issue Mar 22, 2021 that may be closed by this pull request
@Jeckerson Jeckerson merged commit 73dc4e7 into phalcon:4.0.x Mar 22, 2021
@Jeckerson Jeckerson mentioned this pull request Mar 22, 2021
@BeMySlaveDarlin BeMySlaveDarlin deleted the fix/issue-1478-correct-return-type branch May 4, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold Generate
2 participants