New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support finish reason "length" #216

Merged

chr-hertel merged 2 commits into php-llm:main from keboola:odin-finish-reason-length

Feb 18, 2025

Contributor

odinuv commented Feb 18, 2025

The reason is real https://community.openai.com/t/bug-in-api-response-finish-reason-field/287212 and is even mentioned here

llm-chain/src/Bridge/OpenAI/GPT/ResponseConverter.php

Line 159 in 5da000e

* finish_reason: 'stop'|'length'|'tool_calls'|'content_filter',

Plus added some tests for the ResponseConverter


          Fix: support finish reason "length"

7d5a9d5

The reason is real https://community.openai.com/t/bug-in-api-response-finish-reason-field/287212 and is even mentioned here https://github.com/php-llm/llm-chain/blob/5da000ec0fb4fcc4d78399e40eac05506cfff6fc/src/Bridge/OpenAI/GPT/ResponseConverter.php#L159
Plus added some tests for the ResponseConverter

Member

chr-hertel commented Feb 18, 2025

Hi @odinuv & welcome to the project! :)

Good catch and I'm happy to merge as soon as the pipeline is green - I guess php vendor/bin/php-cs-fixer fix should help with that


          chore: fix code style

0ab559d

chr-hertel approved these changes

View reviewed changes

chr-hertel merged commit aff83f9 into php-llm:main

7 checks passed

Member

chr-hertel commented Feb 18, 2025

Thank you @odinuv 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet