Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Rebase auto random counter after restore (#248) #273

Merged
merged 1 commit into from
May 13, 2020

Conversation

3pointer
Copy link
Collaborator

cherry-pick #248 to release-4.0 after pingcap/tidb#16813 merged

What problem does this PR solve?

This PR Fix #241
with this PR we can rebase auto_random increment part counter.

What is changed and how it works?

  1. backup with auto random allocator to get nextGlobalRandID, if table enabled auto_random
  2. set nextGlobalRandID to tableInfo
  3. rebase auto_random counter if table enabled

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to be included in the release note

overvenus
overvenus previously approved these changes May 12, 2020
* *: support auto random backup & restore
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #273 into release-4.0 will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0     #273      +/-   ##
===============================================
+ Coverage        70.97%   71.01%   +0.03%     
===============================================
  Files               48       48              
  Lines             4917     4941      +24     
===============================================
+ Hits              3490     3509      +19     
- Misses             971      974       +3     
- Partials           456      458       +2     
Impacted Files Coverage Δ
pkg/restore/db.go 54.77% <53.84%> (-0.09%) ⬇️
pkg/backup/client.go 71.84% <81.81%> (+0.20%) ⬆️
pkg/backup/push.go 69.35% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bbf30...e9bf8bd. Read the comment docs.

@kennytm kennytm added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 13, 2020
@kennytm kennytm merged commit 208723f into pingcap:release-4.0 May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants