-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collation: add new pinyin collation utf8mb4_zh_pinyin_tidb_as_cs #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about rename utf8mb4_general_zh_ci
to utf8mb4_zh_ci
if we want to follow MySQL's naming convention it should be (note that CLDR also defined the "stroke" and "zhuyin" order, and we could have |
I don't want to follow MySQL's old naming convention, |
🤷 however this collation is explicitly not following (MySQL's implementation of) UCA, otherwise we will be implementing pingcap/tidb#19747. given that the naming convention of all 8.0 collations are
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming it is a typo, rest LGTM.
(btw, are we sure we want case-sensitive ('a' ≠ 'A') not case-insensitive ('a' = 'A') here?)
Co-authored-by: kennytm <[email protected]>
LGTM Thanks for your suggesion @kennytm |
What problem does this PR solve?
add a new collation named
utf8mb4_zh_pinyin_tidb_as_cs
which has collation id2048
proposal pingcap/tidb#19984
tidb PR pingcap/tidb#20504
What is changed and how it works?
a new method to get collation by given id.
Check List
Tests
Code changes