fix now frac in column option #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @winkyao @crazycs520 |
|
any update? |
|
PTAL @winkyao @crazycs520 |
|
LGTM |
|
|
|
Ping @winkyao @crazycs520 |
|
Please remember to update parser version in TiDB go.mod to use this fixed. |
wshwsh12
pushed a commit
to wshwsh12/parser
that referenced
this pull request
Jul 30, 2019
tangenta
pushed a commit
to tangenta/parser
that referenced
this pull request
Sep 28, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#186 is not completely fixed by #211 , this PR parses fraction of CURRENT_TIMESTAMP in ON UPDATE clause.
What is changed and how it works?
ref parsed NowSymOptionFraction in ColumnOption rather than manually construct it.
Check List
Tests
adjusted related parser_test.go