Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add auto_random_base table option #831

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

cherry-pick #823 & #828 to release-3.1
Add auto_random_base table option, so user can specified auto_rand_base when create table or alter table.

What is changed and how it works?

cherry-pick

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@AilinKid AilinKid requested a review from a team April 24, 2020 16:00
@ghost ghost requested review from kennytm and removed request for a team April 24, 2020 16:00
@AilinKid AilinKid requested review from bb7133 and a team and removed request for kennytm April 24, 2020 16:00
@ghost ghost requested review from kennytm and removed request for a team April 24, 2020 16:00
@AilinKid AilinKid requested review from tangenta and a team April 24, 2020 16:00
@ghost ghost removed their request for review April 24, 2020 16:00
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #831 into release-4.0 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           release-4.0     #831   +/-   ##
============================================
  Coverage        78.23%   78.24%           
============================================
  Files               40       40           
  Lines            14700    14706    +6     
============================================
+ Hits             11501    11507    +6     
  Misses            2519     2519           
  Partials           680      680           

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Apr 24, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 merged commit fb338ed into pingcap:release-4.0 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants