Skip the tiflash job. #941
Merged
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test:
1. create table t(id int);
2. ALTER TABLE t SET TIFLASH REPLICA 3 LOCATION LABELS "rack", "host", "abc"; // model.ActionSetTiFlashReplica
3. curl -X POST -d '{"id":45,"region_count":3,"flash_region_count":3}' https://127.0.0.1:10080/tiflash/replica // model.ActionUpdateTiFlashReplicaStatus
4. performance write on table t and check can still replicate.
ref: pingcap/tidb#12453
|
/run-all-tests |
|
/run-all-tests |
crazycs520
reviewed
Apr 3, 2020
drainer/schema.go
Outdated
| switch job.Type { | ||
| case model.ActionUpdateTiFlashReplicaStatus: // empty job.Query | ||
| return true | ||
| case model.ActionSetTiFlashReplica: |
There was a problem hiding this comment.
No need to skip ActionSetTiFlashReplica DDL job? this DDL has Query, How about synchronize this DDL and ignore the error?
|
/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
cherry pick to release-3.1 in PR #942 |
IANTHEREAL
pushed a commit
that referenced
this pull request
Apr 4, 2020
This was referenced Apr 7, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix abort when there'a
model.ActionUpdateTiFlashReplicaStatusjob caused the job.Query is empty:tidb-binlog/drainer/schema.go
Line 280 in cd9a4d1
What is changed and how it works?
Skip the tiflash job.
Check List
Tests
test:
ref: pingcap/tidb#12453
Related changes
Need to cherry-pick to the release branch
Need to be included in the release note