Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove enableAdvertiseAddress field, --advertise-address should be always configured (#2076) #2077

Merged
merged 1 commit into from
Mar 31, 2020
Merged

remove enableAdvertiseAddress field, --advertise-address should be always configured (#2076) #2077

merged 1 commit into from
Mar 31, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 31, 2020

cherry-pick #2076 to release-1.1

What problem does this PR solve?

After #2013, users can set spec.paused to true if they want to avoid tidb-server rolling upgrade in tidb-operator upgrading. Note that users should set it back to false when it's ok to upgrade tidb-server.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

ACTION REQUIRED: `--advertise-address` will be configured for `tidb-server` which will trigger rolling-upgrade for `tidb-server` component, you can set `spec.paused` to `true` to avoid it before upgrading tidb-operator and set it back to `false` when it's ready to upgrade your tidb server.

@sre-bot sre-bot mentioned this pull request Mar 31, 2020
Merged
DanielZhangQD
DanielZhangQD approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 31, 2020

@sre-bot merge failed.

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 31, 2020

/run-all-tests

@cofyc cofyc merged commit 704e164 into pingcap:release-1.1 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@aylei aylei Awaiting requested review from aylei

@LinuxGit LinuxGit Awaiting requested review from LinuxGit

Assignees
No one assigned
Labels
CanMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @DanielZhangQD @Yisaer @cofyc