Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test TestBuiltin fails in different timezone #17013

Closed
SunRunAway opened this issue May 7, 2020 · 8 comments · Fixed by #19963
Closed

unit test TestBuiltin fails in different timezone #17013

SunRunAway opened this issue May 7, 2020 · 8 comments · Fixed by #19963
Labels
challenge-program component/expression component/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented May 7, 2020

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

FAIL: integration_test.go:2131: testIntegrationSuite.TestBuiltin

integration_test.go:2478:
    result.Check(testkit.Rows("2016-01-01 08:00:00.0000"))
/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:61:
    res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
... obtained string = "[2016-01-01 00:00:00.0000]\n"
... expected string = "[2016-01-01 08:00:00.0000]\n"
... sql:select from_unixtime(14516064000/10), args:[]

2. What did you expect to see?

3. What did you see instead?

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

Found in https://circleci.com/gh/pingcap/parser/5436?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

SIG slack channel

#sig-exec

Score

  • 300

Mentor

@SunRunAway SunRunAway added type/bug The issue is confirmed as a bug. component/test labels May 7, 2020
@SunRunAway SunRunAway added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 7, 2020
@wangggong
Copy link
Contributor

/pick-up

@ti-challenge-bot
Copy link

Pick up success.

@sre-bot
Copy link
Contributor

sre-bot commented Sep 14, 2020

Integrity check:
mrs RCA symptom affect_version fix_version fields are empty

@seiya-annie
Copy link

/info

@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 16, 2020

Please edit this comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

@ti-challenge-bot
Copy link

@wangggong You did not submit PR within 7 days, so give up automatically.

@ti-challenge-bot ti-challenge-bot bot removed the picked label Sep 19, 2020
@wangggong
Copy link
Contributor

@SunRunAway issue solved by #19963 .

@ti-srebot
Copy link
Contributor

( FixedVersions AffectedVersions ) fields are empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-program component/expression component/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants