Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support table reader executor read from tiflash. #12371

Merged
merged 7 commits into from
Sep 27, 2019
Merged

executor: support table reader executor read from tiflash. #12371

merged 7 commits into from
Sep 27, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

Support table reader executor read from tiflash.

What is changed and how it works?

Set store type for the Request and move tikv.StoreType to kv.StoreType to avoid import circle.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has persistent data change

Side effects

  • Increased code complexity

@zz-jason
Copy link
Member

@lzmhhh123 CI failed.

@lzmhhh123
Copy link
Contributor Author

/rebuild

@lzmhhh123
Copy link
Contributor Author

@zz-jason ci has been fixed.

@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #12371 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12371   +/-   ##
===========================================
  Coverage   79.8269%   79.8269%           
===========================================
  Files           462        462           
  Lines        102374     102374           
===========================================
  Hits          81722      81722           
  Misses        14774      14774           
  Partials       5878       5878

zz-jason
zz-jason reviewed Sep 25, 2019
View reviewed changes
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 requested a review from zz-jason September 25, 2019 05:36
zz-jason
zz-jason reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2019
qw4990
qw4990 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 095bee9 into pingcap:master Sep 27, 2019
@lzmhhh123 lzmhhh123 deleted the lzm/support_read_tiflash branch September 27, 2019 07:33
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
@lzmhhh123
executor: support table reader executor read from tiflash. (pingcap#1…
7fc76d6 
…2371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@eurekaka eurekaka Awaiting requested review from eurekaka

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @sre-bot @qw4990