plugin: fix plugin build and load with go 1.13 #13455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- revert `-trimpath` - disable `pluginpath`
Codecov Report
@@ Coverage Diff @@
## master #13455 +/- ##
================================================
+ Coverage 80.2044% 80.4282% +0.2237%
================================================
Files 472 472
Lines 114243 114987 +744
================================================
+ Hits 91628 92482 +854
+ Misses 15444 15323 -121
- Partials 7171 7182 +11 |
|
LGTM |
coocood
approved these changes
Nov 14, 2019
|
/merge |
sre-bot
added
the
status/can-merge
lysu
added
status/LGT2
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-2.1 failed |
This was referenced Nov 18, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 19, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 27, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
去掉 pluginpath，是否还是支持多版本同时加载的呢？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #12927
due to Go1.13's issues golang/go#34143 and golang/go#31278 (comment)
we need remove
-trimpathin tidb makefile and-pluginpathin plugin build tool to let plugin can work with go1.13What is changed and how it works?
-trimpathfrom makefilepluginpathin pluginpkgCheck List
Tests
build and load plugin
Code changes
Side effects
Related changes
Release note
This change is