executor: fix wrong plan type for dataReaderBuilder error #17028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #17028 +/- ##
================================================
+ Coverage 79.9685% 80.2619% +0.2933%
================================================
Files 510 510
Lines 138797 140232 +1435
================================================
+ Hits 110994 112553 +1559
+ Misses 18828 18712 -116
+ Partials 8975 8967 -8 |
qw4990
added
status/LGT2
|
@windtalker Should we pick this PR to v3.0.0? |
|
/run-all-tests |
No, only 3.1 is affected. |
|
/merge |
lzmhhh123
approved these changes
May 8, 2020
|
/run-all-tests |
|
@windtalker merge failed. |
lzmhhh123
changed the title
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 8, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #17034 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 8, 2020
|
cherry pick to release-4.0 in PR #17036 |
zz-jason
pushed a commit
that referenced
this pull request
May 9, 2020
sre-bot
added a commit
that referenced
this pull request
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
After PR #16389 TiDB will push down all the expr supported by TiKV or TiFlash in predicate push down stage, so if there is an expr which only supported by TiFlash, a physical selection will be added after index read, but current implementation of
buildExecutorForIndexJoindoes not support physical selection, so it will throw wrong plan type for dataReaderBuilder error when meeting physical selection plan.What is changed and how it works?
What's Changed:
support physical selection in
buildExecutorForIndexJoinRelated changes
Check List
Tests
Release note