Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: migrate test-infra to testify for clustered_index_test #28901

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

tisonkun
Copy link
Contributor

This closes #28323 .

Signed-off-by: tison [email protected]

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2021
@tisonkun
Copy link
Contributor Author

/cc @morgo @mmyj

@ti-chi-bot ti-chi-bot requested review from mmyj and morgo October 18, 2021 05:38
@morgo
Copy link
Contributor

morgo commented Oct 18, 2021

It needs go fmt to be run:

[2021-10-18T05:39:56.307Z] gofmt (simplify)
[2021-10-18T05:40:08.517Z] session/clustered_index_test.go

Signed-off-by: tison <[email protected]>
@tisonkun
Copy link
Contributor Author

@morgo updated.

Also go fmt ./... will introduce redundant change to this PR, see also #28903, it will change br/cmd/tidb-lightning-ctl/main.go also.

@tisonkun tisonkun requested a review from lysu October 19, 2021 00:18
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2021
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2021
@lysu
Copy link
Contributor

lysu commented Oct 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f6a4ed2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2021
@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 236794c into pingcap:master Oct 20, 2021
@tisonkun tisonkun deleted the issue-28323 branch October 20, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for session/clustered_index_test.go
5 participants