Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "parser: Update ServerVersion to 8.0.11" #44744

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 16, 2023

Reverts #42560

As requested by @songrijie

The plan is to re-apply the original PR once the character set improvements are done.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2023
@dveeden dveeden added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Jun 16, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2023
@dveeden dveeden requested review from bb7133, hawkingrei and mjonss June 16, 2023 19:02
@dveeden
Copy link
Contributor Author

dveeden commented Jun 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 17, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-17 06:26:18.211689983 +0000 UTC m=+412574.626294064: ☑️ agreed by hawkingrei.
  • 2023-06-17 08:00:35.044295554 +0000 UTC m=+418231.458899632: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot merged commit a55d196 into master Jun 17, 2023
@ti-chi-bot ti-chi-bot bot deleted the revert-42560-mysql8 branch June 17, 2023 08:35
dveeden added a commit to dveeden/tidb that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants