Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: output backup error from TiKV #58671

Merged
merged 5 commits into from
Jan 16, 2025
Merged

br: output backup error from TiKV #58671

merged 5 commits into from
Jan 16, 2025

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 3, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58666

Problem Summary:
the backup error from TiKV is thrown.

What changed and how does it work?

log warning about the error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth
output backup error
bb798a6 
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 3, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 3, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.1714%. Comparing base (8a33068) to head (2df330f).
Report is 82 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58671        +/-   ##
================================================
+ Coverage   73.1014%   75.1714%   +2.0700%     
================================================
  Files          1677       1700        +23     
  Lines        463645     484112     +20467     
================================================
+ Hits         338931     363914     +24983     
+ Misses       103882      97955      -5927     
- Partials      20832      22243      +1411
Flag Coverage Δ
integration 46.3299% <75.0000%> (?)
unit 72.2865% <75.0000%> (+0.0014%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 64.3506% <75.0000%> (+18.5530%) ⬆️

Leavrth added 2 commits January 3, 2025 17:08
@Leavrth
use error level log
c39c6b3 
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
fix log grammar error
e853a44 
Signed-off-by: Jianjun Liao <[email protected]>
BornChanger
BornChanger reviewed Jan 3, 2025
View reviewed changes
3pointer
3pointer reviewed Jan 16, 2025
View reviewed changes
br/pkg/backup/client.go
@@ -1209,6 +1209,7 @@ func (bc *Client) OnBackupResponse(
if len(errMsg) <= 0 {
errMsg = errPb.Msg
}
logutil.CL(ctx).Error("TiKV encountered an error, interrupting the backup.", zap.String("error message", errPb.Msg))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be errMsg?

@Leavrth
commit some suggestions
2df330f 
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-03 02:50:11.783734888 +0000 UTC m=+664347.139739427: ☑️ agreed by BornChanger.
  • 2025-01-16 03:01:54.725515683 +0000 UTC m=+173986.180561829: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jan 16, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 16, 2025
@ti-chi-bot ti-chi-bot bot merged commit d5dab77 into pingcap:master Jan 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br full backup need to report correct error code when minio is full
3 participants
@Leavrth @3pointer @BornChanger