Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: remove domain init reload when reload time greater than half of schemaLease #58818

Merged
merged 1 commit into from
Jan 21, 2025
Merged

infoschema: remove domain init reload when reload time greater than half of schemaLease #58818

merged 1 commit into from
Jan 21, 2025

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Jan 9, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #58821

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    restart tidb with millions of tables
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 9, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.0555%. Comparing base (9d0fb30) to head (455463c).
Report is 70 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58818        +/-   ##
================================================
+ Coverage   73.1094%   76.0555%   +2.9460%     
================================================
  Files          1676       1731        +55     
  Lines        463866     486546     +22680     
================================================
+ Hits         339130     370045     +30915     
+ Misses       103877      94382      -9495     
- Partials      20859      22119      +1260
Flag Coverage Δ
integration 49.8794% <100.0000%> (?)
unit 73.3304% <100.0000%> (+1.0120%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 64.9171% <ø> (+19.1721%) ⬆️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 9, 2025

/check-issue-triage-complete

zimulala
zimulala approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 13, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 03:43:32.281107254 +0000 UTC m=+757155.569938956: ☑️ agreed by zimulala.
  • 2025-01-13 06:59:26.346296556 +0000 UTC m=+768909.635128262: ☑️ agreed by D3Hunter.

Benjamin2037
Benjamin2037 reviewed Jan 13, 2025
View reviewed changes
pkg/domain/domain.go
}
}
return nil
return do.Reload()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the reload failed with err? here I saw that still need domain.Reload().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, when the reload exceeded half of the lease, we needed to reload again, but now we don’t need to.
If the reload fails here, we will retry at the upper layer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, when the reload exceeded half of the lease, we needed to reload again, but now we don’t need to.
If the reload fails here, we will retry at the upper layer.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 20, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 20, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0c1aa46 into pingcap:master Jan 21, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 left review comments

@D3Hunter D3Hunter D3Hunter approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @hawkingrei @D3Hunter @zimulala @Benjamin2037