-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, workload-based learning: Add common analyze table cost steps in producer part #58930
Conversation
… in producer part step2,3. Group by tablename, get the total scan time, total memory usage, and every table scan time, memory usage, read frequency step4. Calculate table cost for each table, table cost = table scan time / total scan time + table mem usage / total mem usage
Hi @elsa0520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elsa0520: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58930 +/- ##
================================================
+ Coverage 73.1370% 73.6178% +0.4808%
================================================
Files 1678 1680 +2
Lines 464115 465129 +1014
================================================
+ Hits 339440 342418 +2978
+ Misses 103831 101862 -1969
- Partials 20844 20849 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@elsa0520: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@elsa0520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@elsa0520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #58131
Problem Summary:
What changed and how does it work?
Implement the common analyze part for table cost producer part, and add a new struct of tablecost metrics which include (table name, scan time, mem usage, read frequency, table cost)
The common steps are following:
step2,3. Group by tablename, get the total scan time, total memory usage, and every table scan time, memory usage, read frequency
step4. Calculate table cost for each table, table cost = table scan time / total scan time + table mem usage / total mem usage
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.