-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix a bug that global temporary table send cop request (#58882) #59116
base: release-8.1
Are you sure you want to change the base?
executor: fix a bug that global temporary table send cop request (#58882) #59116
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #59116 +/- ##
================================================
Coverage ? 71.2143%
================================================
Files ? 1468
Lines ? 423979
Branches ? 0
================================================
Hits ? 301934
Misses ? 101517
Partials ? 20528
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #58882
What problem does this PR solve?
Issue Number: close #58875
Problem Summary:
What changed and how does it work?
For temporary table, we set a 'dummy' flag to its TableReader/IndexReader/IndexReader etc
So it would be a dummy operation and not sending coprocessor request to tikv.
The bug is that in executor/builder.go, we have
executorBuilder
anddataReaderBuilder
, two difficult code branch.The
dummy
is only set in theexecutorBuilder
...Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.