executor: in-txn statement read from MemBuffer's snapshot #59219
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
|
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59219 +/- ##
================================================
+ Coverage 72.9779% 73.3245% +0.3466%
================================================
Files 1694 1690 -4
Lines 468758 483685 +14927
================================================
+ Hits 342090 354660 +12570
- Misses 105596 107407 +1811
- Partials 21072 21618 +546
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
|
@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
| @@ -254,6 +254,9 @@ type TxnCtxNoNeedToRestore struct { | |||
| // Read results cannot be directly written into pessimisticLockCache because failed statement need to rollback | |||
| // its pessimistic locks. | |||
| CurrentStmtPessimisticLockCache map[string][]byte | |||
|
|
|||
| // MemBufferSnapshot is a snapshot of the memory buffer, every in-txn read of the buffer should use the snapshot to bypass the mutations of current statement. | |||
| MemBufferSnapshot kv.MemBufferSnapshot | |||
There was a problem hiding this comment.
It seems more like a statement-level information. Should it be placed in stmtCtx and initialized OnStmtStart?
| @@ -195,6 +199,34 @@ func getTiDBKeyFlags(flag tikvstore.KeyFlags) kv.KeyFlags { | |||
| return v | |||
| } | |||
|
|
|||
| type snapshot struct { | |||
There was a problem hiding this comment.
Or just name it MemBufferSnapshot since there are many snapshot like definitions in TiDB?
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
you06
force-pushed
the
membuffer-snapshot-interface
branch
from
7c98d0e to
56fdfbc
Compare
ti-chi-bot
bot
added
size/XL
Signed-off-by: you06 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@you06: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #56178, ref #58289
Problem Summary:
What changed and how does it work?
This PR checks the MemBuffer status and fetches a snapshot if necessary before the executors start. This prevents potential data-race operations during the execution of the running executors.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.