-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix a bug that create two views with same name success (#58770) #59370
ddl: fix a bug that create two views with same name success (#58770) #59370
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #59370 +/- ##
================================================
Coverage ? 72.2267%
================================================
Files ? 1417
Lines ? 414280
Branches ? 0
================================================
Hits ? 299221
Misses ? 95075
Partials ? 19984
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/merge |
@tiancaiamao: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #58770
What problem does this PR solve?
Issue Number: close #58769
Problem Summary:
What changed and how does it work?
After one 'create view' ddl job delivered (queuing), the another
create view
ddl job come.The check for table name duplicated is incorrect.
When old table exists and there is no
or replace
, it should report error.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.