Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix traffic replay jobs are shown when the user doesn't have the TRAFFIC_REPLAY_ADMIN privilege #59721

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented Feb 24, 2025

What problem does this PR solve?

Issue Number: close #59712

Problem Summary:
Show traffic jobs and cancel traffic jobs show or cancel replay jobs when the user has TRAFFIC_CAPTURE_ADMIN privilege but not the TRAFFIC_REPLAY_ADMIN privilege.

What changed and how does it work?

  • Fix the typo on privilege
  • Add more info to the error message

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025
Copy link

tiprow bot commented Feb 24, 2025

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4365%. Comparing base (62165a4) to head (6526be8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59721        +/-   ##
================================================
+ Coverage   72.9906%   73.4365%   +0.4459%     
================================================
  Files          1697       1697                
  Lines        468948     469062       +114     
================================================
+ Hits         342288     344463      +2175     
+ Misses       105575     103580      -1995     
+ Partials      21085      21019        -66     
Flag Coverage Δ
integration 42.7841% <0.0000%> (?)
unit 72.2436% <100.0000%> (+0.0574%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1135% <ø> (+0.0338%) ⬆️

@djshow832
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 24, 2025
@djshow832
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 03:25:32.760636084 +0000 UTC m=+326280.713794360: ☑️ agreed by xhebox.
  • 2025-02-25 03:32:52.233353175 +0000 UTC m=+326720.186511441: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 87f6782 into pingcap:master Feb 25, 2025
24 checks passed
@djshow832 djshow832 deleted the replay_priv branch February 25, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic replay jobs are shown when the user doesn't have the TRAFFIC_REPLAY_ADMIN privilege
3 participants