Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix vector indexes do not been dropped on TiFlash side #59733

Merged

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59732

Problem Summary:

What changed and how does it work?

Send sync schema notification to TiFlash when it is a vector index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
Copy link

tiprow bot commented Feb 25, 2025

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @zimulala @breezewish @JaySon-Huang

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @GMHDBJD

@ti-chi-bot ti-chi-bot bot requested a review from GMHDBJD February 25, 2025 03:25
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8150%. Comparing base (62165a4) to head (b156e40).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59733        +/-   ##
================================================
+ Coverage   72.9906%   74.8150%   +1.8244%     
================================================
  Files          1697       1743        +46     
  Lines        468948     477194      +8246     
================================================
+ Hits         342288     357013     +14725     
+ Misses       105575      97664      -7911     
- Partials      21085      22517      +1432     
Flag Coverage Δ
integration 48.8167% <11.1111%> (?)
unit 72.1687% <100.0000%> (-0.0174%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.3192% <ø> (+16.2396%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 25, 2025
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Feb 25, 2025

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Lloyd-Pottiger Lloyd-Pottiger force-pushed the fix-sync-schema-drop-index branch from be05b30 to b156e40 Compare February 25, 2025 05:53
@JaySon-Huang
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 04:00:41.431813622 +0000 UTC m=+328389.384971886: ☑️ agreed by breezewish.
  • 2025-02-25 06:13:33.119323542 +0000 UTC m=+336361.072481810: ☑️ agreed by tangenta.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, JaySon-Huang, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit a95824d into pingcap:master Feb 25, 2025
27 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-sync-schema-drop-index branch February 25, 2025 06:41
@Lloyd-Pottiger
Copy link
Contributor Author

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: new pull request created to branch release-8.5: #59740.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector indexes do not been dropped on TiFlash side
6 participants