Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: always chose the smaller child as outer for IndexJoin #7019

Merged
merged 8 commits into from
Jul 31, 2018
Merged

plan: always chose the smaller child as outer for IndexJoin #7019

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
441e0fe
plan: always chose the smaller child as outer for IndexJoin
zz-jason Jul 9, 2018
da1e12c
Merge branch 'master' into dev/master-indexjoin
ngaut Jul 12, 2018
a52ba2c
Merge branch 'master' into dev/master-indexjoin
zz-jason Jul 30, 2018
041929e
address comment
zz-jason Jul 30, 2018
73f5232
Merge branch 'master' into dev/master-indexjoin
winoros Jul 31, 2018
ecf1f05
Merge branch 'master' into dev/master-indexjoin
zz-jason Jul 31, 2018
d16938c
Merge branch 'master' into dev/master-indexjoin
zz-jason Jul 31, 2018
270b84a
Merge branch 'master' into dev/master-indexjoin
zz-jason Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions plan/exhaust_physical_plans.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,22 +601,29 @@ func (p *LogicalJoin) tryToGetIndexJoin(prop *requiredProp) ([]PhysicalPlan, boo
plans = append(plans, join...)
}
case InnerJoin:
join := p.getIndexJoinByOuterIdx(prop, 0)
if join != nil {
// If the plan is not nil and matches the hint, return it directly.
if leftOuter {
return join, true
}
plans = append(plans, join...)
lhsCardinality := p.Children()[0].statsInfo().Count()
rhsCardinality := p.Children()[1].statsInfo().Count()

leftJoins := p.getIndexJoinByOuterIdx(prop, 0)
if leftOuter && leftJoins != nil {
return leftJoins, true
}
join = p.getIndexJoinByOuterIdx(prop, 1)
if join != nil {
// If the plan is not nil and matches the hint, return it directly.
if rightOuter {
return join, true
}
plans = append(plans, join...)

rightJoins := p.getIndexJoinByOuterIdx(prop, 1)
if rightOuter && rightJoins != nil {
return rightJoins, true
}

if leftJoins != nil && lhsCardinality < rhsCardinality {
return leftJoins, leftOuter
}

if rightJoins != nil && rhsCardinality < lhsCardinality {
return rightJoins, rightOuter
}

plans = append(plans, leftJoins...)
plans = append(plans, rightJoins...)
}
return plans, false
}
Expand Down