expression: fix incorrect uniquote json escapse #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Kingwl
force-pushed
the
fix_unquote_json
branch
from
7d2d53e to
251add2
Compare
|
/run-all-tests |
XuHuaiyu
reviewed
Sep 20, 2018
| @@ -110,7 +110,7 @@ func unquoteString(s string) (string, error) { | |||
| return "", errors.Trace(err) | |||
| } | |||
| ret.Write(char[0:size]) | |||
| i += 5 | |||
| i += 4 | |||
There was a problem hiding this comment.
Should we also make line 105 correct?
XuHuaiyu
added
contribution
jackysp
added
status/all tests passed
and removed
component/expression
contribution
jackysp
added
contribution
Kingwl
force-pushed
the
fix_unquote_json
branch
from
251add2 to
31c736d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
a bug of #7546
What is changed and how it works?
Check List
Tests