-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove constant sort items after substitution #9333
planner: remove constant sort items after substitution #9333
Conversation
/run-all-tests |
This PR fixes the broken integration tests, please review it in a high priority. |
Codecov Report
@@ Coverage Diff @@
## master #9333 +/- ##
==========================================
+ Coverage 67.21% 67.22% +<.01%
==========================================
Files 371 371
Lines 77552 77556 +4
==========================================
+ Hits 52125 52134 +9
+ Misses 20772 20771 -1
+ Partials 4655 4651 -4
Continue to review full report at Codecov.
|
…/zz-jason/tidb into bugfix/remore-constant-sort-item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
fix #9331
What is changed and how it works?
remove remove meaningless constant sort items after column substitution.
Check List
Tests
Related changes