Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-binlog: add the field of ddl_schema_state (#156) (#157) #158

Merged
merged 4 commits into from
Dec 9, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 25, 2019

Cherry-pick #156 to v2.1
Add .circleci/config.yml to make CI work normally, besides update generate-rust.sh and generate-go.sh to make CI happy.

Copy link

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku added the LGT1 one LGTM label Nov 26, 2019
@suzaku
Copy link

suzaku commented Nov 26, 2019

/rebuild

1 similar comment
@zyxbest
Copy link

zyxbest commented Dec 2, 2019

/rebuild

@zimulala zimulala force-pushed the ddl-binlog branch 2 times, most recently from 3af0738 to 53afb53 Compare December 3, 2019 08:11
Copy link
Contributor

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cd $GOPATH/src/github.com/gogo/protobuf
git checkout v0.5
rm $GOPATH/bin/protoc-gen-gofast
go get github.com/gogo/protobuf/protoc-gen-gofast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does version matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file copy from v3.1

@zimulala zimulala merged commit d450976 into pingcap:release-2.1 Dec 9, 2019
@zimulala zimulala deleted the ddl-binlog branch December 9, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGT1 one LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants