avoid reverse array twice

plotly · Mar 29, 2020 · 7511cb1 · 7511cb1
1 parent 2ed2ec8
commit 7511cb1
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js
@@ -559,29 +559,31 @@ module.exports = function setConvert(ax, fullLayout) {
                 Math.min(rl0, rl1),
                 Math.max(rl0, rl1)
             );
-            var axReverse = rl0 > rl1;
-            var signAx = axReverse ? -1 : 1;
 
             if(ax._rangebreaks.length) {
                 for(i = 0; i < ax._rangebreaks.length; i++) {
                     brk = ax._rangebreaks[i];
                     ax._lBreaks += Math.abs(brk.max - brk.min);
                 }
 
+                var axReverse = rl0 > rl1;
+                var signAx = axReverse ? -1 : 1;
+
+                var flip = isY;
+                if(ax.range[0] > ax.range[1]) flip = !flip;
+                if(flip) {
+                    ax._rangebreaks.reverse();
+                }
+
                 ax._m2 = (isY ? -1 : 1) * ax._length / (rl1 - rl0 - ax._lBreaks * signAx);
 
                 if(isY) {
-                    ax._rangebreaks.reverse();
                     // N.B. top to bottom (negative coord, positive px direction)
                     ax._B.push(-ax._m2 * rl1);
                 } else {
                     ax._B.push(-ax._m2 * rl0);
                 }
 
-                if(axReverse) {
-                    ax._rangebreaks.reverse();
-                }
-
                 for(i = 0; i < ax._rangebreaks.length; i++) {
                     brk = ax._rangebreaks[i];
                     ax._B.push(ax._B[ax._B.length - 1] - (isY ? -1 : 1) * ax._m2 * (brk.max - brk.min) * signAx);