-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add barpolar traces #2954
Merged
+2,083
−522
Merged
Add barpolar traces #2954
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
347979c
expose setGroupPositions from bar/set_positions.js
etpinard 8ca4101
don't set undefined class names via Lib.ensureSingle
etpinard 52ed444
:hocho: now useless _module.style loop
etpinard d35d13b
DRY up polar mock cartesian axis 'range' logic
etpinard eb9307e
rename Polar.prototype.isPtWithinSector -> isPtInside
etpinard 4d20388
move a few things to lib/angles.js + add isPtInsideSector
etpinard 95119c4
move polar polygon logic to polar/helper.js
etpinard facb2f8
mv arc/sector/annular path fn to angles.js
etpinard 5ea3d52
update polar baselines post pathSector/pathArc cleanup
etpinard a328b1a
add barpolar :tada:
etpinard dcdd6b5
fix 'date' radial polar axes
etpinard 6edd45e
:lock: barpolar on funky subplots
etpinard 7ae3b7c
bullet-proof barpolar hover
etpinard 0f62c0f
add barpolar mock to svg mock list
etpinard 235b425
add barpolar hover tests
etpinard 6b5895f
add barpolar select test
etpinard 296f088
fixup jsDoc header
etpinard a32484a
do not .classed() layers in ensureSingle if className not given
etpinard e938974
standardize API of polar internal routine
etpinard cd05d3d
confirm use of tip-of-bar/mid-angle pt for selection and hover labels
etpinard 971c6f6
make reversed-radial-axis hover logic more readable
etpinard e6c4dad
align hover label to the left for negative radial coords
etpinard 01e15b4
improve barpolar attribute descriptions
etpinard 160f742
:hocho: comment of rounding up bar borders
etpinard 6494302
change polar bargap 0.2 -> 0.2
etpinard 183b734
set miter-limit to 2 + :lock: in polar_bar-overlay mock
etpinard 452e792
compute bar corners p0/p1/s0/s1 in crossTraceCalc
etpinard e792bc8
add 1e-15 tolerance in isFullCircle
etpinard 8575b27
replace wrap360 with Lib.mod & wrap180 with new Lib.modHalf
etpinard 939bdad
use mod to compute angle delta
etpinard d2484f3
make modHalf restrict output to "half" of Math.abs(input)
etpinard 235fe5b
fixup doc for Lib.modHalf
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which looks like
closeup
with the default
stroke-mitelimit
.