Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stackgl rendering pipeline for transparent traces #4643

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 15, 2020

Thanks to fixes made in #4566 and #4480, this PR could fix #3243 as well as #1267.

@alexcjohnson
Commit 27ba6c1 added various failing tests.
Commit efa3cb7 old work done in gl-plot3d rebased and and applied to update the baselines.

@archmoj archmoj added bug something broken status: reviewable labels Mar 15, 2020
…opacityscale

- update volume mock with extreme opacityscale
@archmoj
Copy link
Contributor Author

archmoj commented Apr 6, 2020

Applied #4725 to update conflicting baseline with extremes opacityscale in 3373d8c.

@jackparmer
Copy link
Contributor

Stumbled upon some nice work that our old colleague Ricky published recently in this area:
https://observablehq.com/@rreusser/faking-transparency-for-3d-surfaces

@alexcjohnson
Copy link
Collaborator

ooh Ricky's demo has some nice features for single-surface presentation - I really like his "cartoon edges" and an option to let the wireframe show through an otherwise opaque surface could be cool. But I don't think this helps us with multiple traces - or a single trace that makes multiple surfaces.

I like the dual depth peeling demo he pointed out - not sure quite what's going on there but it looks promising.

@jackparmer
Copy link
Contributor

This issue has been tagged with NEEDS SPON$OR

A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort.

Sponsorship range: $15k-$20k

What Sponsorship includes:

  • Completion of this feature to the Sponsor's satisfaction, in a manner coherent with the rest of the Plotly.js library and API
  • Tests for this feature
  • Long-term support (continued support of this feature in the latest version of Plotly.js)
  • Documentation at plotly.com/javascript
  • Possibility of integrating this feature with Plotly Graphing Libraries (Python, R, F#, Julia, MATLAB, etc)
  • Possibility of integrating this feature with Dash
  • Feature announcement on community.plotly.com with shout out to Sponsor (or can remain anonymous)
  • Gratification of advancing the world's most downloaded, interactive scientific graphing libraries (>50M downloads across supported languages)

Please include the link to this issue when contacting us to discuss.

@stevendbrown
Copy link

Hi @jackparmer & @archmoj, I'm trying to understand the content of this PR and will be grateful for your help in clarifying what's happening in this PR. It looks like the changes in the PR update or add unit test outputs, but the PR does not include any code to generate those plots, is that right? How were these updated unit test outputs generated if there is no code to generate them?

@archmoj
Copy link
Contributor Author

archmoj commented Aug 4, 2021

Hi @jackparmer & @archmoj, I'm trying to understand the content of this PR and will be grateful for your help in clarifying what's happening in this PR. It looks like the changes in the PR update or add unit test outputs, but the PR does not include any code to generate those plots, is that right? How were these updated unit test outputs generated if there is no code to generate them?

The proposed changes were in gl-plot3d module.
https://github.com/gl-vis/gl-plot3d/compare/gl3d-blend-rebase

@elaude
Copy link

elaude commented May 10, 2024

Hi, what would be needed to push this over the finish line? My usecase would benefit greatly from correct transparency rendering, so I'd be very happy if this could be fixed. I'm willing to contribute the changes needed myself if there's anything blocking this.

@archmoj
Copy link
Contributor Author

archmoj commented May 10, 2024

Hi, what would be needed to push this over the finish line? My usecase would benefit greatly from correct transparency rendering, so I'd be very happy if this could be fixed. I'm willing to contribute the changes needed myself if there's anything blocking this.

@Coding-with-Adam Let's keep track of this for our discussion.
Thanks!

@archmoj
Copy link
Contributor Author

archmoj commented May 16, 2024

Hi, what would be needed to push this over the finish line? My usecase would benefit greatly from correct transparency rendering, so I'd be very happy if this could be fixed. I'm willing to contribute the changes needed myself if there's anything blocking this.

As discussed with @gvwilson I'll try to give this another push (after resolving the merge conflicts) and possibly expose this option via a new attribute.

@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added fix fixes something broken P2 considered for next cycle and removed status: has TODOs bug something broken labels Aug 8, 2024
@archmoj archmoj added this to the v3.0.0 milestone Oct 2, 2024
@archmoj archmoj modified the milestones: v3.0.0, v4.0.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixes something broken P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transparent faces in mesh plots overlap incorrectly
6 participants