-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stackgl rendering pipeline for transparent traces #4643
base: master
Are you sure you want to change the base?
Conversation
- and apply dark blend and power of three
…opacityscale - update volume mock with extreme opacityscale
Stumbled upon some nice work that our old colleague Ricky published recently in this area: |
ooh Ricky's demo has some nice features for single-surface presentation - I really like his "cartoon edges" and an option to let the wireframe show through an otherwise opaque surface could be cool. But I don't think this helps us with multiple traces - or a single trace that makes multiple surfaces. I like the dual depth peeling demo he pointed out - not sure quite what's going on there but it looks promising. |
This issue has been tagged with A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort. Sponsorship range: $15k-$20k What Sponsorship includes:
Please include the link to this issue when contacting us to discuss. |
Hi @jackparmer & @archmoj, I'm trying to understand the content of this PR and will be grateful for your help in clarifying what's happening in this PR. It looks like the changes in the PR update or add unit test outputs, but the PR does not include any code to generate those plots, is that right? How were these updated unit test outputs generated if there is no code to generate them? |
The proposed changes were in gl-plot3d module. |
Hi, what would be needed to push this over the finish line? My usecase would benefit greatly from correct transparency rendering, so I'd be very happy if this could be fixed. I'm willing to contribute the changes needed myself if there's anything blocking this. |
@Coding-with-Adam Let's keep track of this for our discussion. |
As discussed with @gvwilson I'll try to give this another push (after resolving the merge conflicts) and possibly expose this option via a new attribute. |
Thanks to fixes made in #4566 and #4480, this PR could fix #3243 as well as #1267.
@alexcjohnson
Commit 27ba6c1 added various failing tests.
Commit efa3cb7 old work done in
gl-plot3d
rebased and and applied to update the baselines.