Introduce smith subplot and scattersmith trace type
#5956
Conversation
This is just a copy of scatterpolar with a changed name.
This commit also adds a `smith` plot type, which is a copy of polar, with minimal changes needed to host the `scattersmith` trace type.
Also cleaned up code a little bit.
This is to eliminate some state-based errors appearing in the image tests.
| real: { | ||
| valType: 'data_array', | ||
| editType: 'calc+clearAxisTypes', | ||
| description: 'Sets the real coordinates' |
There was a problem hiding this comment.
Can we be more explicit here (and for imag) about what values these should be? Something like "Sets the real component of the data, in units of normalized impedance such that real=1, imag=0 is the center of the chart."
There was a problem hiding this comment.
Good call. Improved by d30416d.
Co-authored-by: Alex Johnson <[email protected]>
|
Alright, I think we're just about there! Aside from my comment about attribute descriptions, my one remaining question is what we want for the default tick/grid values. It's great that the user can specify explicit But then as to what the default values should be: originally I think I asked for just |
Addressed in cfa96e5. |
- and use 0.2, 0.5, 1, 2, 5 set for tickvals
Resolves #4074.
Revise & complete the work of #5615 reflected in the 60c30f4 commit.
@plotly/plotly_js
cc: @jackparmer