Redirect orca process stdout to devnull to prevent write_image deadlock #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only seemed to be causing a problem on windows after more than 20 images had been exported. The reason stdout had previously been set to subprocess.PIPE was to prevent orca's stdout from being displayed in python shell. Setting it to devnull accomplishes the same thing but avoid the deadlock problem
michaelbabyn
pushed a commit
to michaelbabyn/plotly.py
that referenced
this pull request
Dec 22, 2018
) This only seemed to be causing a problem on windows after more than 20 images had been exported. The reason stdout had previously been set to subprocess.PIPE was to prevent orca's stdout from being displayed in python shell. Setting it to devnull accomplishes the same thing but avoid the deadlock problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1255
This only seemed to be causing a problem on Windows after
more than 20 images had been exported.
The reason
stdouthad previously been set tosubprocess.PIPEwas to prevent orca's stdout from being displayed in the python
shell. Setting it to devnull accomplishes the same thing
but avoids the deadlock problem