Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what immediate does #2357

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Clarify what immediate does #2357

merged 2 commits into from
Feb 12, 2025

Conversation

jorisw
Copy link
Contributor

@jorisw jorisw commented Feb 9, 2025

Why

The naming of immediate suggests target styles will be applied instead of running the animation, but this isn't explicitly stated. This makes me unsure of whether I should be using immediate when wanting to skip motion.

What

Clarifies what immediate does to 'prevent' animation

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: 0e8677a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview Feb 10, 2025 6:57pm

joshuaellis
joshuaellis previously approved these changes Feb 10, 2025
@joshuaellis
Copy link
Member

Can you run prettier please?

@joshuaellis joshuaellis merged commit 3403c88 into pmndrs:main Feb 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants