Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert babel runtime #352

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix: revert babel runtime #352

merged 1 commit into from
Apr 8, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 7, 2021

It seems like our trial ('bundled') in #343 was not successful.
We can revisit it, but for now we should fix v3.4.0.

This reverts babel config for CJS to that in v3.3.3. Resolve #351.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 23c8297:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Member Author

dai-shi commented Apr 7, 2021

Does anyone try the codesandbox build? ☝️

@dai-shi
Copy link
Member Author

dai-shi commented Apr 7, 2021

@garth @SimeonGriggs @worstpractice
May I ask you to see if this fixes the issue in v3.4.0 please?

https://ci.codesandbox.io/status/pmndrs/zustand/pr/352/builds/117065

yarn add https://pkg.csb.dev/pmndrs/zustand/commit/23c8297d/zustand
npm i https://pkg.csb.dev/pmndrs/zustand/commit/23c8297d/zustand

@dai-shi
Copy link
Member Author

dai-shi commented Apr 8, 2021

#351 (comment)

Let's ship it.

@dai-shi dai-shi merged commit a68e7b2 into master Apr 8, 2021
@dai-shi dai-shi deleted the fix/babel-runtime branch April 8, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regeneratorRuntime is not defined (after installing 3.4)
1 participant