-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced AlertDialog without AppCompatAlertDialog #924
Conversation
#896 well :( Should not be merged right? |
@@ -54,4 +54,9 @@ | |||
<item name="colorAccent">@color/accent</item> | |||
</style> | |||
|
|||
<style name="Theme.GitHub.Alert.Dialog.Style" parent="Theme.AppCompat.Light.Dialog.Alert"> | |||
<item name="colorAccent">@color/accent</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you setting colorAccent to @color/accent again? its already set in the main theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah. You are right :-)
@StefMa I'd like to use appcompats AlertDialogs, but @hzsweers and @Meisolsson don't |
<style name="Theme.GitHub.Alert.Dialog.Style" parent="Theme.AppCompat.Light.Dialog.Alert"> | ||
<item name="android:textColorPrimary">@color/accent</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the default value for android:textColorPrimary
at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on your main style. With our GitHub . Light it is black...
Ok, let us discuss 👍
So currently we don't need the "more features" which the MaterialDialog-Lib brings on. So, actually it is only overhead on source code.
|
Run the app on a tablet and suddenly we do. Look, this is not a discussion, we're not going to switch to it. It's not a discussion because we have already discussed it. In the future, please abide by the rules we've laid out in our CONTRIBUTING.md about infrastructure changes like this and discuss with us first before assuming anything. Especially considering this was already discussed and decided before. |
See #818 too