-
-
Notifications
You must be signed in to change notification settings - Fork 287
Conversation
548df9e
to
689493c
Compare
Do you think we could use |
You mean having an interactive plot directly in README.md? |
Don't think we can have an interactive plot in the README, but rather taking a screenshot of how the Plotly plot looks like, given that we're favoring |
Just updated the plot by imposing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jorgepiloto! My only comment is that the screenshot is very wide, and it doesn't look very good in the docs:
Wondering if there's a way to shrink it a bit, or otherwise leave the legend out completely and crop the screenshot so that only the axis are shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Request changes)
We could render that plot and make it dynamic in the docs by using: .. jupyter-execute::
:hide-code:
from poliastro.examples import molniya
molniya.plot(interactive=True) If not, I will fix the size 👍🏽 |
That would be cool indeed! We'll need a static plot for the README anyway |
e3746d2
to
ea67498
Compare
a2351ae
to
e12f344
Compare
0a10929
to
e78e413
Compare
1482673
to
6729cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job @jorgepiloto! Left a few comments
a859868
to
c844848
Compare
It looks like the latest version of matplotlib is causing the porkchop features to fail. Let me fix that in a separate pull-request. |
313d17d
to
fa502ae
Compare
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
fa502ae
to
a6b9e62
Compare
The goal of this pull-request is to fix #610. However, I decided to go one step further and update as much as possible our
README.md
file by:svg
logo as the banner image for the repository. It appears now as a centered image.Maintainers
header pointing to a newAUTHORS.md
file.Examples, background and talks
pointing to our talks in conferences.Everything is pure markdown, which esures that PyPI will render properly. Please, take a look to:
https://github.com/jorgepiloto/poliastro/tree/fix/molniya-plot
Before I fix the link to the image for the collage of examples when merging.