Rename the --ponyc option to the full-program-runner #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
chalcolith
approved these changes
Feb 21, 2025
SeanTAllen
force-pushed
the
rename-ponyc-flag
branch
3 times, most recently
from
dec427b to
3a397f5
Compare
|
Not really sure what to say about the errors. @jemc this seems exactly like that "32-bit doing something weird, drop CI and only do "best effort support". I could try this on a 32-bit PI to see if also does this. |
|
I did a "local" test on my 32-bit arm environment and was unable to create the problem we are seeing in CI. I've opened a PR against main to update QEMU to the most recent version. If that passes, I'll merge it then rebase this against that and see if either a) the cache busting that flows from having a new image or b) the update QEMU fixes the issue. |
All runtime options start with --pony so using --ponyc as an option for the program could result in a naming conflict later. This renames from `--ponyc` to `--compiler`.
SeanTAllen
force-pushed
the
rename-ponyc-flag
branch
from
3a397f5 to
9d69ae8
Compare
|
|
|
Looks like updating QEMU did the trick. |
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All runtime options start with --pony so using --ponyc as an option for the program could result in a naming conflict later.
This renames from
--ponycto--compiler.