Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected rows method #1121

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Selected rows method #1121

merged 13 commits into from
Feb 14, 2024

Conversation

gshotwell
Copy link
Contributor

Closes #1120

Gordon Shotwell added 2 commits February 12, 2024 15:52
@gshotwell gshotwell requested a review from schloerke February 12, 2024 20:00
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Get make pyright to pass

Gordon Shotwell and others added 7 commits February 13, 2024 09:30
@gshotwell gshotwell merged commit 6b844e8 into main Feb 14, 2024
26 checks passed
@gshotwell gshotwell deleted the selected_rows-method branch February 14, 2024 23:41
@wch
Copy link
Collaborator

wch commented Feb 15, 2024

A couple module-related questions:

  • Does this work in a module?
  • Does it work if there's a module which returns the renderer object? For example, suppose the module is something like this, and then the server function that instantiates the module wants to get the selected rows:
    @module.server
    def mod_server(input: Inputs, output: Outputs, session: Session): 
        @render.data_frame
        def grid():
            ...
    
        return grid.selected_rows

wch pushed a commit that referenced this pull request Mar 4, 2024
schloerke added a commit that referenced this pull request Mar 6, 2024
* main: (35 commits)
  test: Speed up tests by using single page. Do not attempt deploys job unless conditions are valid (#1197)
  ci: Run `playwright-examples` on Python 3.12 as well (#1195)
  Shiny preset style updates and nudges (#1176)
  tests: Upload trace on failed tests (#1196)
  Fix datetime input in airmass example app (#1194)
  Better docs for `render.download` (#1193)
  Render `shiny.min.css` using `bs_theme()` (#1191)
  Fix `express.ui.update_date` and`express.ui.update_text` links (#1192)
  Use `cast()` for asgiref types only when type checking (#1190)
  Remove uvicorn and click dependencies in Emscripten (#1187)
  Remove asgiref run-time dependency (#1183)
  Install dev-shinylive via Makefile (#1184)
  Put all "Other Changes" items into one section
  Use consistent formatting for items in changelog
  Don't run playwright-deploys tests on release
  tests(resolve-id): Update window size to ensure tooltip is visible (#1179)
  Setup dev version 0.8.0.9000 (#1181)
  Bump version to 0.8.0
  Revert API changes made in `Selected rows method` #1121 (#1174)
  Make autoreload work on codespaces (#1167)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add class-based rows selected method
3 participants