Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nav_panel): Add .bslib-gap-spacing if nav panel is fillable #1154

Merged
merged 5 commits into from
Feb 23, 2024
Merged

fix(nav_panel): Add .bslib-gap-spacing if nav panel is fillable #1154

merged 5 commits into from
Feb 23, 2024

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Feb 23, 2024 •
edited
Loading

Adds the missing .bslib-gap-spacing class to the .nav-panel container when it's fillable.

Fixes #1152

Manual test case

Try setting fillable=True and fillable=False in the example below

from shiny import App, ui

app_ui = ui.page_navbar(
    ui.nav_panel(
        "Page 1",
        ui.card("Card 1"),
        ui.card("Card 2"),
    ),
    sidebar=ui.sidebar("Foo"),
    fillable=True,
    title="foo",
)


app = App(app_ui, None)

fillable=True

image

fillable=False

image

@gadenbuie gadenbuie requested a review from cpsievert February 23, 2024 15:52
cpsievert
cpsievert approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gadenbuie gadenbuie merged commit 5ac456a into main Feb 23, 2024
26 checks passed
@gadenbuie gadenbuie deleted the fix/nav-panel-gap-spacing branch February 23, 2024 16:31
schloerke added a commit that referenced this pull request Feb 27, 2024
@schloerke
Merge branch 'main' into update_row_selection
b7a0a82 
* main:
  Update `@render.data_frame` renderer to work properly with fill/fillable (#1126)
  Don't error on malformed date input (#1139)
  fix(nav_panel): Add `.bslib-gap-spacing` if nav panel is fillable (#1154)
  feat: Add `ui.input_dark_mode()` (#1149)
  chore(make): Add `make docs` and `make docs-preview` (#1150)
  Sync with latest bslib sidebar and card changes (#1129)
  docs(input_task_button): Add to reference index, also update methods for action button/link (#1151)
  chore(make): Update check and check-fix to replicate CI (#1148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page_navbar(fillable=True) with sidebar is missing gap in main content area
2 participants
@gadenbuie @cpsievert