refactor: shiny create and shiny add test supporting functions
#1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
approved these changes
Aug 22, 2024
schloerke
added a commit
that referenced
this pull request
Aug 22, 2024
* main: refactor: `shiny create` and `shiny add test` supporting functions (#1629) Update CHANGELOG.md Fix #1601: Force text/javascript for .js files Work around griffe 1.0 breaking changes feat(shiny create): Support simpler syntax for `--github` flag (#1623) Make sure `Chat.messages(format='google')` converts role assistant -> model (#1622) Fix `NormalizerRegistry.register()` (#1619) Update JS/CSS from shiny and bslib (#1617) Add ability to update `Chat()`'s input placeholder (#1594) docs: Add double-quotes to shiny[theme] (#1605) `json.dump()` each websocket message once instead of twice (#1597)
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Sep 5, 2024
* main: setup.cfg -> pyproject.toml (posit-dev#1625) docs(navset): Add server function to navset docs (posit-dev#1596) Pin syrupy to avoid pytest-rerunfailures incompatibility (posit-dev#1632) refactor: `shiny create` and `shiny add test` supporting functions (posit-dev#1629) Update CHANGELOG.md Fix posit-dev#1601: Force text/javascript for .js files Work around griffe 1.0 breaking changes feat(shiny create): Support simpler syntax for `--github` flag (posit-dev#1623) Make sure `Chat.messages(format='google')` converts role assistant -> model (posit-dev#1622) Fix `NormalizerRegistry.register()` (posit-dev#1619) Update JS/CSS from shiny and bslib (posit-dev#1617) Add ability to update `Chat()`'s input placeholder (posit-dev#1594) docs: Add double-quotes to shiny[theme] (posit-dev#1605) `json.dump()` each websocket message once instead of twice (posit-dev#1597) docs: Update note on style keys allowing for kebab-case (posit-dev#1595) docs: fix navset function links (posit-dev#1590) Get `ui.Chat()` working inside Shiny modules (posit-dev#1582) bug(notification): Allow for duration to be `None` and passed to client (posit-dev#1577) Fix logic for detection of support files in docs (posit-dev#1580) docs(navset): Add examples for navset (posit-dev#1579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves code around. We have a growing number of functions to support the cli interface, which is defined in
_main.py. A large portion of the functions supportingshiny createwere in_template_utils.py, but we also added some of theshiny add testfunctions there as well.This PR uses
_mainas a consistent prefix:_main.py- the CLI definition_main_create.py- functions in support ofshiny create_main_create_custom.py- functions in support of creating custom components_main_add_test.py- functions in support ofshiny add test_main_utils.py- shared functions used by all of the above