Import p3 implementation #1845
Merged
Import p3 implementation #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
This is a prerequisite for #1845 TODO: - [x] narrow down or remove the dead_code exception
|
needs a rebase/merge maybe? |
leonardoalt
reviewed
Sep 27, 2024
.github/workflows/build-cache.yml
Outdated
| - name: Install Rust toolchain 1.77 (with clippy and rustfmt) | ||
| run: rustup toolchain install 1.77-x86_64-unknown-linux-gnu && rustup component add clippy --toolchain 1.77-x86_64-unknown-linux-gnu && rustup component add rustfmt --toolchain 1.77-x86_64-unknown-linux-gnu | ||
| - name: Install Rust toolchain 1.81 (with clippy and rustfmt) | ||
| run: rustup toolchain install 1.81-x86_64-unknown-linux-gnu && rustup component add clippy --toolchain 1.81-x86_64-unknown-linux-gnu && rustup component add rustfmt --toolchain 1.81-x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
These look like rebase/merge leftovers.
ShuangWu121
reviewed
Sep 30, 2024
.github/workflows/pr-tests.yml
Outdated
| - name: Install Rust toolchain 1.77 (with clippy and rustfmt) | ||
| run: rustup toolchain install 1.77-x86_64-unknown-linux-gnu && rustup component add clippy --toolchain 1.77-x86_64-unknown-linux-gnu && rustup component add rustfmt --toolchain 1.77-x86_64-unknown-linux-gnu | ||
| - name: Install Rust toolchain 1.81 (with clippy and rustfmt) | ||
| run: rustup toolchain install 1.81-x86_64-unknown-linux-gnu && rustup component add clippy --toolchain 1.81-x86_64-unknown-linux-gnu && rustup component add rustfmt --toolchain 1.81-x86_64-unknown-linux-gnu | ||
| - name: Install EStarkPolygon prover dependencies |
There was a problem hiding this comment.
looks like the same leftovers from rebase/merge
Schaeff
force-pushed
the
import-p3-implementation
branch
from
9b0ac77 to
2e660d5
Compare
|
Rebased |
leonardoalt
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only a copy paste from https://github.com/powdr-labs/plonky3 with the following exceptions:
preprocessed_widthfunction is moved to theMultiStageAirtrait fromBaseAirto avoid changes top3-airnostdlib.rsis a merge of the existing lib.rs and that of our uni-stark forkprovefunction is removed, as it is only there for compatibility with uni-stark testsFieldMerkleTreeMmcswas renamed toMerkleTreeMmcsin plonky3 since we forked it. Our configs use this type and the name is updated accordinglyTODO: