-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Cannot find module 'extract-text-webpack-plugin' with [email protected] #214
Comments
@thangngoc89 can't able to reproduce. Might be because during installation of node_modules, something got missed. Can you try removing node_modules and reinstalling them? |
@reznord I reproduced this twice. |
Apparently, npm installed it but node can't resolve it
And yes, I removed node_moduels and re-install it twice |
Looks like an |
Same issue if you try to use npx to create a new app:
Which otherwise would be an awesome way to use preact-cli. |
@slaskis Actually it's how I discovered this bug. :D . Wanted to try out npx on [email protected] |
sounds like an npm dedupe issue |
@developit My point still stand. We are importing extract-text-webpack-plugin directly in the code, so we should install directly |
I agree with @thangngoc89. Webpack 3 has separated the plugin totally. I guess it is better to install it separately. |
@reznord Could you make a PR to replace |
@thangngoc89 ayeee... PR enroute. 😄 |
@thangngoc89 we are not using that anywhere as of now. Edit: Oops, didn't see that. Got it. Gonna push it soon. |
@reznord I'm not follow. We're using extract-text-webpack-plugin but not webpack-block/extract-text2. |
Got this error using the latest NPM, was able to "fix" by simply using yarn instead. For anyone stuck: Then |
^^ Ahh interesting, I didn't realize we had moved off of webpack-blocks for this already. Definitely best to add it as a dependency then. |
We also got to the same problem. The current issue rises when we don't install preact-cli globally and use it from the |
@anantoghosh webpack3 will be available in the next version (which might take sometime) because there are a bunch of things which we are planning for the next release |
@anantoghosh if you can send a PR to back port that change to preact-cli, I'll be happy to merge it |
I wouldn't do that! Since it is already changed in webpack branch, that might just lead us to conflicts while merging it. |
@reznord this is a bug and we should fix it asap. Since webpack 3 will be a major change and the release day is pretty much unclear. I would recommend back port the fix and release a new version |
Well, in that case it is fine. (: |
- Extract-text-webpack-plugin - Chalk Closes #214
Error:
Reproduce:
preact create test && cd $_
npm start
P/s:
This only happens with [email protected]. For some reason, node can't resolve it
My rule of thumb is if you use it, you must install it first. Thoughts @developit @lukeed ?
The text was updated successfully, but these errors were encountered: