Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor enabled with default create #95

Closed
filoxo opened this issue Jun 7, 2017 · 2 comments
Closed

Preprocessor enabled with default create #95

filoxo opened this issue Jun 7, 2017 · 2 comments

Comments

@filoxo
Copy link

filoxo commented Jun 7, 2017

If I understand the docs correctly, CSS preprocessors are optional and should be false by default1.

 $ preact create

  --less      Pre-install LESS support                 [boolean]  [default: false]
  --sass      Pre-install SASS/SCSS support            [boolean]  [default: false]

But a clean install adds bunch of LESS files.

~/dev » preact --version
preact-cli 1.1.0
~/dev » preact create test-pwa && cd test-pwa 
✔ Done!
dev/test-pwa » tree ./src 
|____src
| |____routes
| | |____home
| | | |____index.js
| | | |____style.less
| | |____profile
| | | |____index.js
| | | |____style.less
| |____style
| | |____helpers.less
| | |____index.less

Are the docs incorrect, or am I mistaken?

@filoxo
Copy link
Author

filoxo commented Jun 7, 2017

Found that #3 also notes that LESS shouldn't be default.

@filoxo
Copy link
Author

filoxo commented Jun 7, 2017

Ah, and #32 (comment) notes that

the --less / --sass flags actually don't affect the app generated by create at all right now

as of 2 weeks ago. That answers my question for the time being. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant